Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6296] Add CI support + git ignore update #10

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

phvalguima
Copy link
Collaborator

This PR adds the following changes:

  • Minor updates to config.yaml
  • Add CI support for GH
  • Update gitignore

@@ -44,13 +45,6 @@ def test_next_state_clean():
assert lifecycle.next(DPBenchmarkLifecycleTransition.CLEAN) == DPBenchmarkLifecycleState.UNSET


def test_next_state_stop():
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be added back in the next stages, once we have pyright fixes and TLS

Copy link

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few remarks attached. Nothing critical, but worth addressing to have a solid CI

Also, please make sure we have a green CI

deusebio
deusebio previously approved these changes Jan 17, 2025
Copy link

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor comments

@phvalguima phvalguima merged commit 7048560 into main Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants