-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-6296] Add CI support + git ignore update #10
Conversation
@@ -44,13 +45,6 @@ def test_next_state_clean(): | |||
assert lifecycle.next(DPBenchmarkLifecycleTransition.CLEAN) == DPBenchmarkLifecycleState.UNSET | |||
|
|||
|
|||
def test_next_state_stop(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be added back in the next stages, once we have pyright fixes and TLS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few remarks attached. Nothing critical, but worth addressing to have a solid CI
Also, please make sure we have a green CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor comments
This PR adds the following changes: